redactor add: Add optional filtering like env vars#3605
Open
DrJosh9000 wants to merge 1 commit intomainfrom
Open
redactor add: Add optional filtering like env vars#3605DrJosh9000 wants to merge 1 commit intomainfrom
DrJosh9000 wants to merge 1 commit intomainfrom
Conversation
DrJosh9000
force-pushed
the
vars-filter-flag
branch
from
df8571e to
ac935bb
Compare
DrJosh9000
force-pushed
the
vars-filter-flag
branch
from
ac935bb to
b5deb35
Compare
zhming0
approved these changes
Jan 7, 2026
Contributor
zhming0
left a comment
zhming0
left a comment
There was a problem hiding this comment.
Looks good, looks useful 👍🏿
| }, | ||
| cli.BoolFlag{ | ||
| Name: "apply-vars-filter", | ||
| Usage: fmt.Sprintf("When the input is in 'json' format, filters the secrets to redact using the same rules used to detect secrets from environment variables: secrets must be at least %d characters long, and names must match the patterns defined by --redacted-vars or $BUILDKITE_REDACTED_VARS.", redact.LengthMin), |
Contributor
There was a problem hiding this comment.
Coming from an angle of not famlilar with agent redactor mechanism, I don't think I understand this feature without the code. Maybe we can use some touch up on the doc here, something alone the line of:
"By default, all values in the JSON will be redacted. When apply-vars-filter is true, only ... gets redacted".
But it's not a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an
--apply-vars-filterflag to theredactor addsubcommand, that enables the same filtering as normally happens for filtering env vars for secrets.Context
Relevant to #3588
Changes
--apply-vars-filteras described above, and the common--redact-varsflag.Two small cleanups:
unknown format "foo"rather thanfoo: unknown formatTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I did it my way